ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Update Iris pin to avoid using versions with memory issues #2407

Closed ehogan closed 3 months ago

ehogan commented 3 months ago

Is your feature request related to a problem? Please describe. Iris v3.7.0 and v3.8.0 contains a regridding memory leak.

Therefore, Iris v3.7.1, v3.8.1 or >= v3.9 must be used to avoid the regridding memory leak.

The current pin is >=3.8.0, so I propose updating the pin to >3.8.0. This is equivalent to including !=3.7.0,!=3.8.0, which @valeriupredoi proposed in the TLT meeting just now 👍

Instructions to update dependencies are available at ESMValCore documentation: Dependencies.

Would you be able to help out? @chrisbillowsMO, would it be possible for you to do this, please? 😁

valeriupredoi commented 3 months ago

indeed! i was looking at a slightly older environment.yml - a iris >3.8.0 pin sounds good to me, cheers @ehogan :beer:

chrisbillowsMO commented 3 months ago

Docs for ESMValCore dependencies here

Only two files to update which chimes with:

Change made in:

  • [X] environment.yml contains dependencies that cannot be installed from PyPI/Julia package registry

  • [X] setup.py contains all Python dependencies, regardless of their installation source

setup.py contains this a comment linking to this issue comment: https://github.com/ESMValGroup/ESMValTool/issues/3239#issuecomment-1613298587

I'm wondering if this comment is now resolved by pinning >3.8.0 and should be removed? @bouweandela @valeriupredoi @ehogan

ehogan commented 3 months ago

setup.py contains this a comment linking to this issue comment: ESMValGroup/ESMValTool#3239 (comment)

I'm wondering if this comment is now resolved by pinning >3.8.0 and should be removed? @bouweandela @valeriupredoi @ehogan

@chrisbillowsMO I will propose updating the comment to now point to this issue instead 👍

ehogan commented 3 months ago

Docs for ESMValCore dependencies here

Apologies for linking to the incorrect documentation! I'll update this in the first comment 👍