ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Pin numpy<2.0.0 to avoid pulling 2.0.0rcX #2415

Closed valeriupredoi closed 3 months ago

valeriupredoi commented 3 months ago

Description

We should pin numpy <2 for the release - David Hassell pulled the rc1 in the cfpython env, here's what I wrote to him this is the bug in pip that makes possible a pre package get pulled in https://github.com/pypa/pip/issues/7579 and real world case for the same issue you had here https://github.com/Unidata/cftime/issues/327 - slim chances for us to hit this bug, since all's been fine so far, but better err on the safe side!

@ehogan @chrisbillowsMO I think it'd be safe to include this in the release, maybe just after ESMValCore rc1, so it doesn't mess with your current procedures. Once numpy=2 stable is out, and we've fixed all the wiggles (ours or not) via https://github.com/ESMValGroup/ESMValCore/pull/2395 then we can unpin. Cheers :beer:


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.51%. Comparing base (a782af8) to head (fc269ae).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2415 +/- ## ======================================= Coverage 94.51% 94.51% ======================================= Files 246 246 Lines 14020 14020 ======================================= Hits 13251 13251 Misses 769 769 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 3 months ago

cheers @bouweandela :beer: