Closed valeriupredoi closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.51%. Comparing base (
a782af8
) to head (fc269ae
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cheers @bouweandela :beer:
Description
We should pin numpy <2 for the release - David Hassell pulled the rc1 in the cfpython env, here's what I wrote to him this is the bug in pip that makes possible a pre package get pulled in https://github.com/pypa/pip/issues/7579 and real world case for the same issue you had here https://github.com/Unidata/cftime/issues/327 - slim chances for us to hit this bug, since all's been fine so far, but better err on the safe side!
@ehogan @chrisbillowsMO I think it'd be safe to include this in the release, maybe just after ESMValCore rc1, so it doesn't mess with your current procedures. Once numpy=2 stable is out, and we've fixed all the wiggles (ours or not) via https://github.com/ESMValGroup/ESMValCore/pull/2395 then we can unpin. Cheers :beer:
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the π Technical or π§ͺ Scientific review.
To help with the number pull requests: