Remove compilers dependency from conda environment and force install x64 git in OSX Github Action workflows

valeriupredoi commented 3 months ago

Description

Closes #2419

compilers was added by @bouweandela four years ago in #603 - see https://github.com/ESMValGroup/ESMValCore/pull/603#issuecomment-631651179 - I don't think we still need it but may be worth checking the docker build goes well without it anyway

OSX tests: failing with "setuptools_scm._run_cmd.CommandNotFoundError: git" - this has been seen in https://github.com/ESMValGroup/ESMValTool/pull/3581 and it's not hitting just this node, but rather, it's an endemic issue related to macOS 14 on arm64:

  Image: macos-14-arm64
  Version: 20240422.3
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240422.3/images/macos/macos-14-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240422.3

For some reason, the system git goes fishing when the x64 environment is activated and used - @schlunma and I had a decent debate about it in the linked Tool PR - no time to really-really understand the issue, just plop a git installer in the workflow!

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title and labels
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.51%. Comparing base (6786bd9) to head (9741e3a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2420 +/- ## ======================================= Coverage 94.51% 94.51% ======================================= Files 246 246 Lines 14023 14023 ======================================= Hits 13254 13254 Misses 769 769 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 3 months ago

Thanky, bud 🍺

ESMValGroup / ESMValCore