Closed valeriupredoi closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.51%. Comparing base (
6786bd9
) to head (9741e3a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanky, bud ๐บ
Description
Closes #2419
compilers
was added by @bouweandela four years ago in #603 - see https://github.com/ESMValGroup/ESMValCore/pull/603#issuecomment-631651179 - I don't think we still need it but may be worth checking the docker build goes well without it anywayOSX tests: failing with "setuptools_scm._run_cmd.CommandNotFoundError: git" - this has been seen in https://github.com/ESMValGroup/ESMValTool/pull/3581 and it's not hitting just this node, but rather, it's an endemic issue related to macOS 14 on arm64:
For some reason, the system git goes fishing when the x64 environment is activated and used - @schlunma and I had a decent debate about it in the linked Tool PR - no time to really-really understand the issue, just plop a git installer in the workflow!
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐ Technical or ๐งช Scientific review.
To help with the number pull requests: