Fix bug in `_rechunk_aux_factory_dependencies`

ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.

https://www.esmvaltool.org

Apache License 2.0

40 stars 36 forks source link

Fix bug in `_rechunk_aux_factory_dependencies` #2428

Closed ehogan closed 1 month ago

ehogan commented 1 month ago

Description

Closes #2427

Link to documentation:

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title and labels
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Changes are backward compatible
[x] 🛠 All checks below this pull request were successful

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.51%. Comparing base (690e6a7) to head (9115bf0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2428 +/- ## ======================================= Coverage 94.51% 94.51% ======================================= Files 246 246 Lines 14023 14023 ======================================= Hits 13254 13254 Misses 769 769 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 1 month ago

Cheers @ehogan 🍺 I'd review this myself, but I'd not be 100% confident with my review, best bod to review it is @bouweandela

valeriupredoi commented 1 month ago

Brill, cheers, both 🍺