ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
40 stars 36 forks source link

Preserve cube attribute global vs local when concatenating #2449

Closed bouweandela closed 1 month ago

bouweandela commented 1 month ago

Description

Preserve cube attribute global vs local as well as possible in esmvalcore.preprocessor.concatenate. See iris.cube.CubeAttrsDict for more information.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.62%. Comparing base (1da5bbc) to head (8262ec2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2449 +/- ## ======================================= Coverage 94.61% 94.62% ======================================= Files 246 246 Lines 14048 14055 +7 ======================================= + Hits 13292 13299 +7 Misses 756 756 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

katjaweigel commented 1 month ago

Looks good, thanks! A short test version of recipe_martin18grl.yml (renamed because git does not like yml) runs with this branch of the core but not with v2.11.x recipe_martin18grl_yml_test.txt

bouweandela commented 1 month ago

@ehogan @chrisbillowsMO It might be nice to include this in the v2.11 release if possible.

chrisbillowsMO commented 1 month ago

@ehogan @chrisbillowsMO It might be nice to include this in the v2.11 release if possible.

Nice is our speciality! Cherry picked in here!