Fix units and `valid_range` of AIRS-2-0

schlunma commented 3 months ago

Description

Fixes https://github.com/ESMValGroup/ESMValTool/issues/3680

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🧪 The new functionality is relevant and scientifically sound
[x] 🛠 This pull request has a descriptive title and labels
[x] 🛠 Code is written according to the code quality guidelines
[x] 🧪 and 🛠 Documentation is available
[x] 🛠 Unit tests have been added
[x] 🛠 Changes are backward compatible
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 The list of authors is up to date
[x] 🛠 All checks below this pull request were successful

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

schlunma commented 3 months ago

The two recipes mentioned in https://github.com/ESMValGroup/ESMValTool/issues/3680 look fine with this change :tada:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.62%. Comparing base (f2496b6) to head (5d7c05c). Report is 32 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2465 +/- ## ======================================= Coverage 94.62% 94.62% ======================================= Files 246 247 +1 Lines 14055 14065 +10 ======================================= + Hits 13299 13309 +10 Misses 756 756 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlunma commented 3 months ago

Thanks V! Let's adapt the fix if we need it. The file has not changed since 2019, so I guess we should be fine for some time 😁

valeriupredoi commented 3 months ago

Thanks V! Let's adapt the fix if we need it. The file has not changed since 2019, so I guess we should be fine for some time 😁

Plan, Batman :bat:

ESMValGroup / ESMValCore