More reliable datasets to recipe conversion

bouweandela commented 2 weeks ago

Description

Make the _to_frozen accept more types of input data to avoid a crash.

Closes #2466

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🧪 The new functionality is relevant and scientifically sound
[x] 🛠 This pull request has a descriptive title and labels
[x] 🛠 Code is written according to the code quality guidelines
[x] 🧪 and 🛠 Documentation is available
[x] 🛠 Unit tests have been added
[x] 🛠 Changes are backward compatible
[x] 🛠 The list of authors is up to date
[x] 🛠 All checks below this pull request were successful

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.61%. Comparing base (495176a) to head (1f1b2aa).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2472 +/- ## ========================================== - Coverage 94.62% 94.61% -0.01% ========================================== Files 247 247 Lines 14057 14060 +3 ========================================== + Hits 13301 13303 +2 - Misses 756 757 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlunma commented 2 weeks ago

I think I know now what's going on in #2466. In summary, datasets from two different rootpaths might have different facets in the input directory DRS which may lead to different types of the facet values.

Unfortunately, this PR does not fix that problem; I am still getting the same errors.

ESMValGroup / ESMValCore