ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Run a nightly test with the development version of dependencies #2478

Closed bouweandela closed 1 month ago

bouweandela commented 2 months ago

Description

Add a nightly test with development versions of upstream packages, to signal problems early. As agreed at the tech lead team meeting on 2024-07-02.

Other changes in this pull request:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.64%. Comparing base (7291433) to head (dfcb585).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2478 +/- ## ======================================= Coverage 94.64% 94.64% ======================================= Files 249 249 Lines 14114 14114 ======================================= Hits 13358 13358 Misses 756 756 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 1 month ago

ie what I meant by issues: both installation issues resulted from dependency conflicts (unevened environments yet to be evened at release times by all those guys); also scientific/numerical/deprecation troubles eg iris depends on cartopy, but cartopy decides to change something in their dev code, iris dev picks up the conda cartopy so all's fine, but when dev cartopy is installed, iris barfs, and we don't know who needs to fix what - we really don't want to start acting like the US Marines going everywhere to solve everyone else's problems :grin:

ehogan commented 1 month ago

Thanks @bouweandela! ๐Ÿฅณ

The only question I have is: I think we're bound to catch a few too many issues if we test against the dev versions of all those packages, and maybe we get lost in understanding what's going on, should we not just use it for iris, as @ehogan initially suggested in the TLT minutes?

I had this same question ๐Ÿ˜Š We could see how it goes testing all these packages and if it gets too noisy we could review? ๐Ÿค”

bouweandela commented 1 month ago

We could see how it goes testing all these packages and if it gets too noisy we could review? ๐Ÿค”

That sounds like a great plan!

valeriupredoi commented 1 month ago

I had this same question ๐Ÿ˜Š We could see how it goes testing all these packages and if it gets too noisy we could review?

@ehogan that's exactly why I approved, but in light of me last comment, I think this may go downhill at some point :grin: