ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

fix `access-mapping.yml` extra_facets title #2485

Closed rhaegar325 closed 1 month ago

rhaegar325 commented 1 month ago

Description

make a slight change in title of access-mapping.yml to avoid a potential bug

Closes #2483

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

rbeucher commented 1 month ago

Thanks @rhaegar325. Why this was not picked by the tests?

rbeucher commented 1 month ago

Tests are failing. @rhaegar325 please have a loop as soon as possible.

rbeucher commented 1 month ago

Also. Can you explain the bug in more details, please? for the records

rbeucher commented 1 month ago

@rhaegar325 We usually use dataset: ACCESS-ESM1-5 not ACCESS_ESM1_5

rhaegar325 commented 1 month ago

@rbeucher, now this error has been fixed. The bug is caused by we deside to change the file name of our cmoriser from access_esm.py to access_esm1_5.py. but I did not change the title in extra_facets access-mapping.yml, so when we use the cmoriser it can not load the extra_facets. Also, in test_access_esm1_5.py, I did not change the dataset name to ACCESS-ESM1-5, so the test didn't pick this error up. silly mistake, won't happen again.