ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Switch to new iris >= 3.10.0 API #2500

Closed schlunma closed 1 month ago

schlunma commented 1 month ago

Description

Iris introduces a couple new features and also some breaking changes in v3.10.0:

I opted for pinning iris instead of making it backwards-compatible so we can use all new features, which allows us to remove lots of lines in our code.

Addresses https://github.com/ESMValGroup/ESMValCore/issues/2492


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.70%. Comparing base (f969e82) to head (3a7a180). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2500 +/- ## ======================================= Coverage 94.69% 94.70% ======================================= Files 248 248 Lines 14071 14001 -70 ======================================= - Hits 13324 13259 -65 + Misses 747 742 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 1 month ago

excellent, many thanks for taking on this one, Manu! Lemme know when you need a review :beer:

schlunma commented 1 month ago

Since iris released v.3.10.0 today, this is ready for review now!

valeriupredoi commented 1 month ago

will do a more reviewey review tomorrow, in the meantime, be advised of this for future rc_iris stuffs https://github.com/conda-forge/iris-feedstock/issues/115

schlunma commented 1 month ago

@bouweandela please merge if you're happy with this ๐Ÿ‘

schlunma commented 1 month ago

Thanks V for reviewing ๐Ÿป