Remove ability to log on to ESGF

bouweandela commented 1 month ago

Description

Logging in is no longer needed to download data from ESGF and OpenID 2.0 servers are being shut down and will be replaced by OpenID Connect at some point (but maybe not for downloading).

Closes #2491 Closes #1766 Closes #1631

Link to documentation: https://esmvaltool--2508.org.readthedocs.build/projects/ESMValCore/en/2508/quickstart/configure.html#esgf-configuration

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🧪 The new functionality is relevant and scientifically sound
[x] 🛠 This pull request has a descriptive title and labels
[x] 🛠 Code is written according to the code quality guidelines
[x] 🧪 and 🛠 Documentation is ~available~ has been deleted
[x] 🛠 Unit tests have been ~added~ removed
[x] 🛠 Changes are backward compatible
[ ] 🛠 ~Any changed dependencies have been added or removed correctly~
[x] 🛠 The list of authors is up to date
[x] 🛠 All checks below this pull request were successful

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.69%. Comparing base (4c21ca6) to head (3e1234d).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2508 +/- ## ========================================== - Coverage 94.71% 94.69% -0.02% ========================================== Files 249 248 -1 Lines 14123 14071 -52 ========================================== - Hits 13376 13324 -52 Misses 747 747 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bouweandela commented 1 month ago

That warning was already removed in #2326, are you sure you're using this branch?

sloosvel commented 1 month ago

Yes, I was just using the wrong environment, all looks good now!

ESMValGroup / ESMValCore