Closed schlunma closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.79%. Comparing base (
f622e40
) to head (5968487
). Report is 9 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ESMValGroup/technical-lead-development-team could one of yous please have a last look at this then merge? :beer:
Description
While performing tests for https://github.com/ESMValGroup/ESMValTool/pull/3784, I noticed that our fixes do not use our own unit conversion function, which allows special unit conversions like m -> DU.
This PR adds this, but uses a "safe" version of the unit conversion which will not allow a change of the cube's
standard_name
(this would lead to errors in the subsequent CMOR checks).Note: I had to restructure the functions a little bit to avoid circular imports.
Related to
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐ Technical or ๐งช Scientific review.
To help with the number pull requests: