Closed valeriupredoi closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.77%. Comparing base (
f622e40
) to head (16c762a
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cheers @bettina-gier - good point, the issue I am pointing to here is actually a more up to date one, for Tool I'd have to open yet another PR to get that in in a comment, and by now, I reckon you've had enough of these reviews, so I don't want to scare off our new techie bod :grin:
but - excellent review BTW - this is what we want - reviewers to pay attention to all the details, not like me - approve a Draft PR :rofl:
if you're just changing the link in the tool I can approve it without having to think, so all good. Better to be consistent than to save those 5min
if you're just changing the link in the tool I can approve it without having to think, so all good. Better to be consistent than to save those 5min
sounds good - let me do that after I merge this :smiley:
Description
Related to https://github.com/ESMValGroup/ESMValTool/issues/3782 - currently
conda-lock
is struggling with mamba>=2 but Ben Mares atconda-lock
has fixed the issue, and all we need to do is wait for a major release ofconda-lock
; in the meantime the workaround is to pin mamba in the Github action, so we can get our lock file generated.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐ Technical or ๐งช Scientific review.
To help with the number pull requests: