ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

pin mamba in conda lock creation github action #2561

Closed valeriupredoi closed 1 month ago

valeriupredoi commented 1 month ago

Description

Related to https://github.com/ESMValGroup/ESMValTool/issues/3782 - currently conda-lock is struggling with mamba>=2 but Ben Mares at conda-lock has fixed the issue, and all we need to do is wait for a major release of conda-lock; in the meantime the workaround is to pin mamba in the Github action, so we can get our lock file generated.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.77%. Comparing base (f622e40) to head (16c762a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2561 +/- ## ======================================= Coverage 94.77% 94.77% ======================================= Files 251 251 Lines 14266 14266 ======================================= Hits 13520 13520 Misses 746 746 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 1 month ago

cheers @bettina-gier - good point, the issue I am pointing to here is actually a more up to date one, for Tool I'd have to open yet another PR to get that in in a comment, and by now, I reckon you've had enough of these reviews, so I don't want to scare off our new techie bod :grin:

valeriupredoi commented 1 month ago

but - excellent review BTW - this is what we want - reviewers to pay attention to all the details, not like me - approve a Draft PR :rofl:

bettina-gier commented 1 month ago

if you're just changing the link in the tool I can approve it without having to think, so all good. Better to be consistent than to save those 5min

valeriupredoi commented 1 month ago

if you're just changing the link in the tool I can approve it without having to think, so all good. Better to be consistent than to save those 5min

sounds good - let me do that after I merge this :smiley: