ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Support Python 3.13 #2566

Open valeriupredoi opened 1 month ago

valeriupredoi commented 1 month ago

Description

Potential roadblock https://github.com/SciTools/iris/pull/6195

Good news! The race to support Python 3.13 is a lot shorter than 3.12, we have the following roadblocks, in the process of unblocking:

That's it! We fixed esgf-pyclient for 3.13 recently (today), and all else goes through!

~Prerequisites needs https://github.com/ESMValGroup/ESMValCore/pull/2395~ merged via main merge in d1dc683f3564b61117eb5690f24f5bc704565842


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.66%. Comparing base (9b9a125) to head (cffb96f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2566 +/- ## ======================================= Coverage 94.66% 94.66% ======================================= Files 251 251 Lines 14287 14287 ======================================= Hits 13525 13525 Misses 762 762 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

valeriupredoi commented 3 weeks ago

@ESMValGroup/technical-lead-development-team @trexfeathers @ESadek-MO some very good news wrt ESMValCore and iris=3.11 and Numpy>2 and Python 3.13 - using the release candidate for iris=3.11 we are now fully covered for Numpy>2 and Python 3.13 support - environment solves smoothly, and the tests that fail are the ones I fixed in https://github.com/ESMValGroup/ESMValCore/pull/2395 (ie all related to Numpy 2.0+ API and functionality/deprecations); am very happy since the transition to both these important dependencies' updates (Numpy and Python, no sweat, iris :grin: ) is all but complete, without having to go though the hell I went through for Python 3.12 support :partying_face: :beers:

valeriupredoi commented 2 weeks ago

iris==3.11 is out as of 10min ago https://anaconda.org/conda-forge/scitools-iris

valeriupredoi commented 2 weeks ago

look gents @bouweandela @schlunma - green :green_circle: - we good to get in Python 3.13 :partying_face:

valeriupredoi commented 2 weeks ago

That's a good find @bouweandela - they should have pinned Python in their conda recipe if 3.13 is a no-go, will ping them myself, see if I can expedite the adoption 🍺

bouweandela commented 2 weeks ago

Maybe no code changes are needed in Iris to support Python 3.13, since the tests here are all passing fine. Let's keep an eye on that PR and with a bit of luck things will just work.

valeriupredoi commented 2 weeks ago

Maybe no code changes are needed in Iris to support Python 3.13, since the tests here are all passing fine. Let's keep an eye on that PR and with a bit of luck things will just work.

yup, just gonna put that reference in here in the description so it's clear off the bat - am also gonna go ask them, asking never killed anyone, except that guy that asked Henry VIII where was his wife :grin:

valeriupredoi commented 2 weeks ago

hey bud @bouweandela have a look at this https://github.com/SciTools/iris/pull/6195#issuecomment-2470676025 , that means we good to go with this :beer:

valeriupredoi commented 6 days ago

hey bud @bouweandela have a look at this SciTools/iris#6195 (comment) , that means we good to go with this 🍺

@bouweandela let's get this one in, when you have a minute, given :arrow_up: