ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
218 stars 127 forks source link

Remove unused NCL plot routines #1044

Closed mattiarighi closed 5 years ago

mattiarighi commented 5 years ago

Some of the plotting routines in esmvaltool/diag_script/shared/plot/*.ncl are currently not used and will never be used, because the diagnostics using them have already been or will be ported in a different language (like the monsoon diagnostics). It would be good to remove them before the next release.

These include:

Furhtermore taylor_diagram.ncl and taylor_diagram_less_hardcoded.ncl could probably be merged in a single file (@axel-lauer ?) and the routines in legends.ncl could become part of aux_plotting.ncl.

zklaus commented 5 years ago

I will port the monsoon diagnostics, and yes, they will be in python.

mattiarighi commented 5 years ago

Will it be also the case for the mjo recipes? They are available on the private repo only, at the moment.

zklaus commented 5 years ago

I guess so. I will be in touch with Shiyu, who still works here and worked on the original mjo diagnostics.

hb326 commented 5 years ago

The functions and procedures in misc_function.ncl are indeed still needed in eyring06jgr and eyring13jgr, even in v2. It is fine to move them to aux_plotting.ncl.