ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
217 stars 127 forks source link

Switch to iris3 testing #1862

Closed valeriupredoi closed 3 years ago

valeriupredoi commented 3 years ago

Steps towards validation and inclusion of iris3

Install against source-installed esmvalcore with iris3

Run some recipes

Test conda and PyPi package builds

valeriupredoi commented 3 years ago

I'd like to ask some peeps to run some recipes but am afraid to do that just now since we'll ask them to run all the recipes for the upcoming esmvaltool 2.1 release next week :grin:

stefsmeets commented 3 years ago

I just tried to run the tests with the iris3 branch of esmvalcore. The good news is that the tests passed right away! The bad idea is that we have no idea how some of the recipes are affected.

I found a few instances of extract_strict, which I have updated (these avoided the tests apparently). I could not find any obvious dimensionless sigmas.

modified:   esmvaltool/cmorizers/obs/nsidc_common.py
modified:   esmvaltool/diag_scripts/autoassess/autoassess_area_base.py
modified:   esmvaltool/diag_scripts/autoassess/land_surface_permafrost/permafrost.py
modified:   esmvaltool/diag_scripts/autoassess/land_surface_surfrad/surfrad.py
modified:   esmvaltool/diag_scripts/shared/_supermeans.py
stefsmeets commented 3 years ago

Created a PR here: #1874

valeriupredoi commented 3 years ago

good stuff, cheers @stefsmeets :beer:

stefsmeets commented 3 years ago

Spent some time looking for the way to install the iris3 branch of esmvaltool, these commands work for me 👍

conda create -n esmvaltool-iris3 -c esmvalgroup -c conda-forge esmvalcore
conda env update -n esmvaltool-iris3 -f environment.yml
pip install -e .[develop]
bouweandela commented 3 years ago

Preferably, it should be possible to install by checking out the branch from #1874, creating a conda environment with the environment.yml from that branch and doing a pip install -e .[develop] for both ESMValTool and ESMValCore (i.e. following the installation from source instructions from the documentation for the iris3 branch).