search

ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
223 stars 128 forks source link

Move diagnostic helper functions to ESMValCore #1873

Open jvegreg opened 4 years ago

jvegreg commented 4 years ago

Talking about the deployment of ESMValCore 2.1 in BSC, @sloosvel and I realized that it is not that useful for us because all our diagnostics are using the helper functions that we have in esmvaltool/diag_scripts/shared.

If we really want users to be able to develop their diagnostics using just ESMValCore, we must move them to the core.

What do you think, @ESMValGroup/esmvaltool-developmentteam ?

stefsmeets commented 4 years ago

Great idea! I have not been involved with the project for super long, but one thing I have noticed that ESMValCore and ESMValTool are very tightly coupled. ESMValCore should really be able to stand by itself. I actually opened a somewhat related issue last week: https://github.com/ESMValGroup/ESMValCore/issues/826

bouweandela commented 4 years ago

I agree that it would be a good idea to move some functions to the ESMValCore, but we would need to make a selection and clean up a bit, as there are currently two interfaces implemented and quite a bit of stuff that is not generic enough to move to the core. We need to make sure that the code in the core does not grow into a many headed spaghetti monster.