ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
217 stars 126 forks source link

Prepare release 2.4.0 #2354

Closed zklaus closed 2 years ago

zklaus commented 2 years ago

Dear @ESMValGroup/esmvaltool-developmentteam,

version 2.4.0 of ESMValTool is approaching fast.

On Monday, we released ESMValCore 2.4.0rc1, the release candidate of the core that this ESMValTool release will be based on. Today we are entering the feature freeze for ESMValTool 2.4.0, which means that no new features will be merged anymore, restricting further changes to bugfixes.

Please help us testing the new version by running your own recipes with the latest development version.

Special attention

One particular change in ESMValCore requires attention from all recipe maintainers. In ESMValGroup/ESMValCore#1332 a new required field was added to recipes. Please check #2324 and make sure that the recipes that you are maintaining get a title.

The release is planned for Monday next week. A few days of delay are possible.

valeriupredoi commented 2 years ago

that's brilliant, many thanks @remi-kazeroni :beer:

katjaweigel commented 2 years ago

Unfortunately, recipe_flato13ipcc.yml does still not run completely, after #2390 was merged: There is an additional issue in ch09_fig09_14.py where a double scalar time coordinate is caused by different scalar time coordinates in the models (differ by one day or 12 hours). Because of this the multi-model mean fails. See issue #2401. I'm testing if the rest of recipe_flato13ipcc.yml runs without this diagnostic and without several data sets.

remi-kazeroni commented 2 years ago

I have re-run several of the recipes marked failed in https://esmvaltool.cloud.dkrz.de/shared/esmvaltool/v2.4.0-test2/ and for which a fix (removing write_plots, lack of computing power, missing data,...) (see the results in this comment). I am not sure how I could share the results so that maintainers could check the plots from their recipes. At the moment results are stored in my Mistral account. [edited]

remi-kazeroni commented 2 years ago

@ESMValGroup/esmvaltool-recipe-maintainers, failed recipes from the previous set of tests have been rerun to check whether these run fine with the latest fixes in the code. Could you please check your recipes ran successfully and that the plots and provenance information are correct? The link to the results is: https://esmvaltool.cloud.dkrz.de/shared/esmvaltool/v2.4.0-test3/

The runs were done with the same settings as the original tests for this release, expect recipe_bock20jgr_fig_6-7,yml, recipe_eyring13jgr_12.yml, recipe_smpi_4cds, recipe_spei and recipe_wenzel16jclim which used max_parallel_task=1.

valeriupredoi commented 2 years ago

cheers muchly Remi!

56 - 19 + 2 (not ran before) = 39 recipes failed

Still we have 39 that poop the bed?

remi-kazeroni commented 2 years ago

Out of the currently failing recipes from this list of outstanding issues, 20 out of 24 failures are due to missing data. Out of this list of reran recipes, we have 5 more failed recipes. In short, perhaps less than 10 recipes failing for reasons not related to missing data.

katjaweigel commented 2 years ago

I finally managed to run a version of recipe_flato13ipcc.yml with reducing the data (Removing data missing on Mistral, one model where a model fix seems to be necessary and correcting a non fitting time range for one model). The output can be found on Mistral at: /work/bd1083/b380216/output/recipe_flato13ipcc_20211104_231212 (I haven't manage to check all the figures, yet.)

recipe_flato13ipcc.yml.diff.txt recipe_flato13ipcc.yml.txt

zklaus commented 2 years ago

Thanks, everyone for the hard work! Most issues have been resolved, the few remaining ones will be tracked for the next release.

valeriupredoi commented 2 years ago

cheers @zklaus and everyone else! We are finally ready-ready to release :guitar: