Fix provenance logger functionality in `thermodyn_diagtool/plot_script.py`

ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP

https://www.esmvaltool.org

Apache License 2.0

210 stars 123 forks source link

Fix provenance logger functionality in `thermodyn_diagtool/plot_script.py` #2413

Open valeriupredoi opened 2 years ago

valeriupredoi commented 2 years ago

Currently not working, @schlunma generalized the prov fixing in #2296 (cheers!) but this is not enough for this particular case. See l.84-107 in diag_scripts/thermodyn_diagtool/plot_script.py

schlunma commented 2 years ago

@valeriupredoi Release v2.5 is approaching quickly (the feature freeze will be on 2022-02-21). Since this issue is marked for v2.5, could you briefly comment if you further intend to include this in the new release and/or if you are facing any problems with it? Thanks!!

schlunma commented 2 years ago

Moving this to v2.6.

sloosvel commented 2 years ago

If this is not ready, can it be removed from the milestone?

valeriupredoi commented 1 year ago

I a moving it to ze future, really zilch time to even think about looking at it, it'd be nice if the recipe/diag authors could have a stab at it though

ValerioLembo commented 1 year ago

Hi, not sure what the issue is here. I am not on the project anymore (it's been a while actually). @valeriupredoi can you wrap it up a bit so that I can see if there is anything I can do? Or maybe even @schlunma could bring up the error.