ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
226 stars 128 forks source link

Update stratosphere recipe #2724

Open KatherineTomkins opened 2 years ago

KatherineTomkins commented 2 years ago

Short description of the diagnostic Remove AutoAssess component dependency from the stratosphere recipe. See https://code.metoffice.gov.uk/trac/cma/browser/autoassess/trunk/autoassess/assessment_areas/stratosphere for the original stratosphere code in AutoAssess.

Branch and pull request Once you've started working, add the branch (and pull request)

valeriupredoi commented 2 years ago

hi @KatherineTomkins great to see this being tackled! Could I ask you a couple things please:

Cheers muchly! :beer:

valeriupredoi commented 2 years ago

sorry forgot to say - please add me and @alistairsellar as reviewers to all Autoassess in ESMValTool-related (that already exists, that is) work :+1:

KatherineTomkins commented 2 years ago

Currently paused to prioritise other work.

katjaweigel commented 11 months ago

Not sure if this is the right place to mention, but I found two small issues with recipe_autoassess_stratosphere.yml:

1) There is a wrong time axis in the QBO plot for model data: The recipe says 1997-2002, but the axis ticks claim the data would start in 1968 This can seen in https://esmvaltool.dkrz.de/shared/esmvaltool/v2.10.0/debug.html, e.g. Figure: https://esmvaltool.dkrz.de/shared/esmvaltool/v2.10.0/recipe_autoassess_stratosphere_20231212_210642/plots/aa_strato/autoassess_strato_test_1/MPI-ESM-MR_vs_MPI-ESM-LR/stratosphere/MPI-ESM-LR_qbo.png Also in the documentation (https://docs.esmvaltool.org/en/latest/recipes/recipe_autoassess_stratosphere.html) the time axis in this figures seems rather unusual. 2) I tried to switch from ERA-Interim to ERA5 and did not succeed, it seemed to be still searching for ERA-Interim at some point I'll try to find out what is wrong there, but not this year anymore :)

alistairsellar commented 10 months ago

Hi @katjaweigel, thanks for spotting these issues. I think that this is a good place to mention it, as it looks to me like the PR (when complete) could solve at least one of these issues. I will see about getting the PR moving again. To help prioritise, do you have an immediate dependency on these plots?

katjaweigel commented 10 months ago

Hi @alistairsellar thanks a lot for your answer! I just started to look into Stratospheric data aiming to better understand gravity wave parametrizations and trying to find out, what ESMValTool can already do.