search

ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
217 stars 127 forks source link

Recipes with (some) issues discovered during the 2.7.0 release runs #2943

Closed valeriupredoi closed 1 year ago

valeriupredoi commented 1 year ago

We have a couple outstanding issues unearthed during the last release recipe testing runs, and I summarize them here. Both these recipes are maintainer-orphaned so it would be very nice and helpful if we could find some good hearts from the @ESMValGroup/esmvaltool-developmentteam that could volunteer to look at and fix the issues, and even nicer, if they could sign themselves up as one or more recipe maintainers. Eternal gratitude will be offered in exchange, and a :beer: at the next workshop :grin:

Cheers!

remi-kazeroni commented 1 year ago

I plan to reuse this approach of listing broken recipes for v2.8 so that broken recipes might start receiving more attention. If some broken recipes are really unmaintained, we could start counting for how many releases, apply our broken recipe policy and think of retiring these recipes after 3 releases. It seems that only recipe_modes_of_variability.yml was listed this time but more could have been flagged as broken. If the broken recipe is fixed before the release or if the recipe runs fine during the testing, this issue will be closed. Otherwise, this will be moved to v2.9.

valeriupredoi commented 1 year ago

I plan to reuse this approach of listing broken recipes for v2.8 so that broken recipes might start receiving more attention. If some broken recipes are really unmaintained, we could start counting for how many releases, apply our broken recipe policy and think of retiring these recipes after 3 releases. It seems that only recipe_modes_of_variability.yml was listed this time but more could have been flagged as broken. If the broken recipe is fixed before the release or if the recipe runs fine during the testing, this issue will be closed. Otherwise, this will be moved to v2.9.

@remi-kazeroni I have managed to ignore this, sorry bud! Cool! I take it these recipes are now broken the second time round, so they'll get sidelined next release...

bouweandela commented 1 year ago

It looks like the first recipe listed above was not actually broken and the second recipe has been fixed, so there may be no need for that.

valeriupredoi commented 1 year ago

thanks Bouwe, had a closer look meself - all is out of the water now, one less issue for @remi-kazeroni to look into :partying_face: