search

ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
224 stars 128 forks source link

Tests in full development mode fail after PR 3040 #3061

Closed valeriupredoi closed 1 year ago

valeriupredoi commented 1 year ago

After PR #3040 we got consistent fails of five recipe loader tests when running with the latest development main of ESMValCore, see fails

schlunma commented 1 year ago

Nice! this tells us which recipes need updates because of 1609, so we can extend the list here: https://github.com/ESMValGroup/ESMValTool/issues/3056

I assume this test uses ESGF data only, right? Reciperecipe_schlund20jgr_gpp_change_1pct.yml ran fine with local data, but due to the facet issue of CanESM2 for supplementary variables this still fails when ESGF data is needed.

valeriupredoi commented 1 year ago

this is just a mocker, Manu - it don't download any data - there is an issue with the mask_landseaice and recipe checker, it thinks it needs at least one supplementary variable but sftgif is a default - @bouweandela could you have a look pls, mate :beer:

schlunma commented 1 year ago

Yeah, that makes sense.

The thing is that I am getting very similar errors when trying to run these recipes with only ESGF data (e.g., the problem that CanESM2 fx variables cannot be found), so I thought this code is actually checking ESGF. Before changing anything in this test, we should check if these recipes actually run with ESGF data only. Maybe it works with these updated recipes...

valeriupredoi commented 1 year ago

am just running recipe_collins13ipcc.yml on Levante with latest mains from Core and Tool - it's running fine, at least the read recipe stage passed through, so that test issue is a mocking issue - ooop it died:

ERROR   Looked for files matching
/work/bd0854/DATA/ESMValTool2/CMIP5_DKRZ/CSIRO-QCCCE/CSIRO-Mk3L-1-2/rcp45/mon/atmos/Amon/r1i2p1/*/tas/tas_Amon_CSIRO-Mk3L-1-2_rcp45_r1i2p1*.nc
/work/bd0854/DATA/ESMValTool2/download/cmip5/output1/CSIRO-QCCCE/CSIRO-Mk3L-1-2/rcp45/mon/atmos/Amon/r1i2p1/*/tas/tas_Amon_CSIRO-Mk3L-1-2_rcp45_r1i2p1*.nc
/work/bd0854/b309141/additional_CMIP5/CSIRO-QCCCE/CSIRO-Mk3L-1-2/rcp45/mon/atmos/Amon/r1i2p1/*/tas/tas_Amon_CSIRO-Mk3L-1-2_rcp45_r1i2p1*.nc

but that's OK - some issue that's prob not needing a Core change

remi-kazeroni commented 1 year ago

Seems that is still the case, see tests.