ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 122 forks source link

Deprecations from external packages, that will become errors soon (no, not the Neil Diamond song :rofl: ) #3208

Open valeriupredoi opened 1 year ago

valeriupredoi commented 1 year ago

So, since we now have a brand spanking new environment supporting Python=3.11 (cheers for merging my baby PR @bouweandela :beer: ), I took a closer look at the warnings we get from the CI tests, and I notice two potentially error-y deprecations, see test run -

../../../../../usr/share/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/esmpy/init.py:107 ../../../../../usr/share/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/esmpy/init.py:107 /usr/share/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/esmpy/init.py:107: DeprecationWarning: Implicit None on return values is deprecated and will raise KeyErrors. homepage = msg["Home-page"]

../../../../../usr/share/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/esmpy/init.py:108 ../../../../../usr/share/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/esmpy/init.py:108 /usr/share/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/esmpy/init.py:108: DeprecationWarning: Implicit None on return values is deprecated and will raise KeyErrors. obsoletes = msg["obsoletes"]



@schlunma knowing Philip updates the psyplot package decently regularily I wouldn't worry too much, but, you know...just in case, might be a good idea to send him a nudge. About the esmpy warning, again, let's not go all guns blazing to them, but just to keep it in mind :nerd_face: 
billsacks commented 1 year ago

For the ESMPy issue, see https://github.com/esmf-org/esmf/issues/140 -- I'll try to address that.

valeriupredoi commented 11 months ago

cheers muchly @billsacks - sorry, I fired and forgot about this one :grin:

ehogan commented 1 week ago

@valeriupredoi I have just started seeing the __author__ = msg["Author"] issue in the new environment I just created for the release (I didn't see this problem at all using the first environment I created for the release). They both contain the same version of esmpy though 🤔

(old-env) % conda list esmpy
# packages in environment at /miniforge3/envs/old-env:
#
# Name                    Version                   Build  Channel
esmpy                     8.4.2              pyhc1e730c_4    conda-forge
(new-env) % conda list esmpy
# packages in environment at /miniforge3/envs/new-env:
#
# Name                    Version                   Build  Channel
esmpy                     8.4.2              pyhc1e730c_4    conda-forge

Any thoughts? 😕