CMORizer Australian Gridded Climate Data(AGCD) precipitation

flicj191 commented 11 months ago

Description

Add CMORizer for Australian Gridded Climate Data (AGCD) for use by the Australian climate community.

For this issue #3444
Link to documentation:
- *

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[ ] 🛠 Code is written according to the code quality guidelines
[ ] 🛠 Documentation is available
[ ] 🛠 Tests run successfully
[ ] 🛠 The list of authors is up to date
[ ] 🛠 Any changed dependencies have been added or removed correctly
[ ] 🛠 All checks below this pull request were successful

New or updated data reformatting script

[x] 🛠 Documentation is available
[x] 🛠 The dataset has been added to the CMOR check recipe
[x] 🛠 The dataset has been added to the shared data pools of DKRZ and Jasmin by the @ESMValGroup/OBS-maintainers team
[x] 🧪 Numbers and units of the data look physically meaningful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

flicj191 commented 11 months ago

Hi @valeriupredoi, thanks for your help and quick response! I think the only Codacy issues left are the unused func args for cmorization() - not sure how you would handle these? Thanks!

valeriupredoi commented 11 months ago

hi @flicj191 many thanks for plugging in the changes! All good about Codacy now - that's supposed to raise that issue (we'll have to fix the args in the main cmorizer, but not here, been meaning to do that for a wee while now). This is getting closer to be ready now, I'll have a look in detail at the changes :+1:

rbeucher commented 11 months ago

@flicj191 I think you need to update the documentation as well: doc/sphinx/source/input.rst

See example here: https://github.com/ESMValGroup/ESMValTool/pull/1799/files

flicj191 commented 11 months ago

@valeriupredoi thanks for your help, I have cleaned up and adjusted the calculation for month days, haven't included leap years though this would be a small error for the data product.

valeriupredoi commented 11 months ago

cheers @flicj191 - PR looks very good, am gonna approve from a technical stand point, and maybe @rbeucher can approve it from the scientific side (or, suggest more changes). The last remaining point is to have the data cmorized and plopped onto a server that contains OBS datasets for regular ESMValTool analyses - that was done by a colleague who has left a couple months ago, so I'll have to figure out who is doing that now. In the meantime, do you guys have a mirror of the DKRZ OBS dir down south yet? Maybe you can put the data there, if there is already a place. At any rate, one bit at a time, let me approve :beer:

rbeucher commented 11 months ago

We have a mirror of the DKRZ obs folder yes, but no process to sync it with DKRZ. I have access to Levante but probably not the rights to add observation datasets.

valeriupredoi commented 11 months ago

OK good to know @rbeucher - can anyone from the @ESMValGroup/obs-maintainers please run the CMORizer and upload the data to DKRZ? Cheers :beer:

axel-lauer commented 10 months ago

OK good to know @rbeucher - can anyone from the @ESMValGroup/obs-maintainers please run the CMORizer and upload the data to DKRZ? Cheers 🍺

I just tried to download the data in order to run the CMORizer. It is, however, not clear to me how to do this. When I tried to create and NCI account (with my work email address) I get the following error message:

You cannot use this email address because its domain is not in our list of allowed email domains. Please use an official institutional/work email address. If that is not accepted, please contact the NCI Helpdesk for assistance.

I am not sure I want to go through the effort of contacting the NCI help desk, so i'd appreciate other ideas.

rbeucher commented 10 months ago

That's what happened to me at DKRZ 😂.

rbeucher commented 9 months ago

@axel-lauer, I have copied the AGCD raw dataset on Levante. You can find it here: /work/bd0854/b382685/agcd.tar.gz Let me know how it goes.

rbeucher commented 9 months ago

The Licence is CC-BY4.0-NC. Maybe this could go to Tier2?

flicj191 commented 9 months ago

Thanks for your review @axel-lauer I have added in those changes, Tier 2 sounds good to me. The time bounds must have come from the raw files so I have added in the correction. Cheers!

rbeucher commented 8 months ago

I also think this one is ready @valeriupredoi

ESMValGroup / ESMValTool