search

ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 123 forks source link

CI tests failing because of scikit-learn #3504

Closed valeriupredoi closed 5 months ago

valeriupredoi commented 6 months ago

scikit-learn ==1.4.0 released 3 days ago is not a happy bunny with our CI tests

valeriupredoi commented 5 months ago

@schlunma any clues as to why the new scikit-learn is not playing ball? :beer:

schlunma commented 5 months ago

Yeah, they changed their API slightly. Working on this in https://github.com/ESMValGroup/ESMValTool/tree/fix_sklearn_tests.

valeriupredoi commented 5 months ago

Good man Manu 🍺

valeriupredoi commented 5 months ago

afraid I must reopen this, I hate it when I do this but it must - unfortunately we have to pin scikit-learn because if we don't, tests fail with older versions see the condalock tests https://github.com/ESMValGroup/ESMValTool/actions/runs/7628345703/job/20779171979 - the version in the lock file is scikit-learn-1.3.2-py311hc009520_2 - @schlunma would you be comfortable to pin scikit-learn to the latest version (1.4.0)? :beer:

valeriupredoi commented 5 months ago

or alternatively do the version checks with two API variants in the code - which are a pain and it's totally not worth it