ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
218 stars 127 forks source link

Pin pytest <8.0.0 #3514

Closed valeriupredoi closed 8 months ago

valeriupredoi commented 8 months ago

Description

new pytest=8.0.0 pulls in a very old pytest-metadata (2.0.0) while conflicting with the newer version (3.0.0, that holds the env vars that pytest is looking for), see https://github.com/conda-forge/pytest-feedstock/issues/170 for more details; I'll try help at the pytest feedstock, but in the meantime, we should pin pytest to less than 8.0.0 (also a good idea for now, since the new version seems to be rather buggy) - reason for this is pytest-metadat has a hard pin on pytest<8 see https://github.com/conda-forge/pytest-metadata-feedstock/blob/main/recipe/meta.yaml

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

bouweandela commented 8 months ago

Would it make sense to instead pin pytest-metadata to >= 3 if that is actually what we need?

valeriupredoi commented 8 months ago

yes, that may be another (probably more sound) option (though usually one pins the more important package first, pytest-metadata being just a plugin, though a pesky one here) - but, in the meantime, maybe this will go though fast enough for us not to pin anything https://github.com/conda-forge/pytest-metadata-feedstock/pull/15

valeriupredoi commented 8 months ago

https://github.com/conda-forge/pytest-metadata-feedstock/pull/15 just got merged so that should fix all aour problems - gonna close (for now, surely forever)