search

ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 123 forks source link

[CI/pytest=8.0.0] Couple MLR test fails with new `pytest` #3516

Closed valeriupredoi closed 5 months ago

valeriupredoi commented 5 months ago

@schlunma have a looksee at these failed tests - I can fix them for you if you are busy :beer:

valeriupredoi commented 5 months ago

3517 nearly fixed this, but it seems pytest=8 is sneaking up on you again, Manu https://app.circleci.com/pipelines/github/ESMValGroup/ESMValTool/11179/workflows/01d8b6e8-b03e-4fcf-9136-654f718239b3/jobs/71735/tests

schlunma commented 5 months ago

Why did this not show up in the test runs of CircleCI? :face_exhaling:

bouweandela commented 5 months ago

Because those still used pytest 7

bouweandela commented 5 months ago

Remember that to make the tests run quickly, the CircleCI run_tests job makes use of a docker container that is built from the main branch whenever something is merged to main, so it can sometimes be a bit behind on dependencies. The other tests that do create a new environment are not run on a pull request by default, only if you make changes to the dependencies or CircleCI configuration files.

valeriupredoi commented 5 months ago

that's why I should have turned on GH Actions tests on said PR, but was all too eager to merge and have the tests fixed in main :man_facepalming:

schlunma commented 5 months ago

Yeah, but the PR with the new pytest has been merged yesterday, I thought it already used the new container. Anyway, will open a new PR in a minute.

schlunma commented 5 months ago

https://github.com/ESMValGroup/ESMValTool/pull/3518