ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 123 forks source link

OceanSODA-ETHZ data file has been replaced/updated #3533

Closed TomasTorsvik closed 5 months ago

TomasTorsvik commented 5 months ago

Describe the bug A clear and concise description of what the bug is. If you are developing a new diagnostic script, please provide a link to the code/branch on GitHub that you are working in.

Please attach

I was trying to download the OceanSODA-ETHZ dataset, running esmvaltool data download OceanSODA-ETHZ and get error message 404 NotFound.

Looking at esmvaltool data info OceanSODA-ETHZ I see that the script will try to download the file OceanSODA-ETHZ_GRaCER_v2021a_1982-2020.nc from source https://www.ncei.noaa.gov/data/oceans/ncei/ocads/data/0220059/, but the file is not present there. Instead I find a file OceanSODA_ETHZ-v2023.OCADS.01_1982-2022.nc, so presumably the dataset has been replaced and/or updated?

Probably it's just a matter of updating the CMORizer script, if the new dataset only extends the old one, but I don't know if this is the case.

TomasTorsvik commented 5 months ago

@schlunma @remi-kazeroni @valeriupredoi I tag you on this issue since it seems you were involved when the cmorization script for OceanSODA-ETHZ was introduced in PR #2915

TomasTorsvik commented 5 months ago

Actually, from the README file for the dataset it seems there may have been some changes introduced in a previous version (v2022), so the current file may not be backwards compatible with v2021a. https://www.ncei.noaa.gov/data/oceans/ncei/ocads/data/0220059/README_v2023.pdf

schlunma commented 5 months ago

Could you try to change the path in the code and then re-run the CMORizer (download and format) again? If that works well, we could just update the existing code and data.

TomasTorsvik commented 5 months ago

The CMORizer for OceanSODA-ETHZ works after replacing all instances of OceanSODA-ETHZ_GRaCER_v2021a_1982-2020.nc with OceanSODA_ETHZ-v2023.OCADS.01_1982-2022.nc. Will make a PR for this.