ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
218 stars 127 forks source link

recreate perfmetric plots in python #3551

Open lukruh opened 6 months ago

lukruh commented 6 months ago

Description

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script


To help with the number of pull requests:

valeriupredoi commented 6 months ago

what a noble venture, Lukas! Godspeed :checkered_flag: :beer:

lukruh commented 5 months ago

So far we used the distance_metrics prerpocessor from within the recipe, which works but has some limitations in practise and can lead to messy recipes. I added an optional function to apply it from within the plot diagnostic. I.e. use reference_metric: rmse in the script section of the recipe instead of the distance_metric preprocessor. The reference_for_metric facet for the reference dataset i.e. ERA-interim is still required. @diegokam if you are available, you could have a look and try to adjust the recipe accordingly.

mo-gill commented 5 months ago

Hi, we are currently working on the ESMValTool release for v2.11.0. We're wondering if you'd be able to complete this PR by the end of next week (Friday 10th May).

Otherwise, please let us know, and we'll move it into the next milestone for you :slightly_smiling_face:

lukruh commented 5 months ago

I don't see this PR be ready until next week. The next milestone is more realistic I'd say.

rbeucher commented 3 months ago

I just came across this. It looks great. Any progress?

schlunma commented 3 months ago

I just came across this. It looks great. Any progress?

We are working on it ๐Ÿ˜„ It's planned to include this in v2.12