ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 122 forks source link

Add imagehash package as an ESMValTool dependency #3557

Closed alistairsellar closed 3 months ago

alistairsellar commented 3 months ago

Description

For recipe_test_workflow, and also fixing the errors that occurred when merging #3435, add imagehash package as a dependency.

3436 talked about "development dependency", but think that "test" section may be more appropriate, since used by esmvaltool/utils/testing/regression/compare.py which is for test purposes. Test appears to be sufficient for inclusion in docker build also.

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.

alistairsellar commented 3 months ago

@valeriupredoi does this cover what is needed for adding imagehash as a dev/test dependency?

I've done everything in https://docs.esmvaltool.org/en/latest/community/code_documentation.html#dependencies but should I check anything else?