search

ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
217 stars 127 forks source link

Pin esmpy <8.6.0 #3585

Closed valeriupredoi closed 4 months ago

valeriupredoi commented 5 months ago

Description

Sister PR to https://github.com/ESMValGroup/ESMValCore/pull/2402

issues with iris-esmf-regrid mentioned by @schlunma in https://github.com/SciTools-incubator/iris-esmf-regrid/pull/342#issuecomment-2092921514 and confirmed by me in MO/ANCIL-ANTS, see https://github.com/valeriupredoi/ANTS_stuff/blob/main/ANTS_JASMIN.md - no issue raised at ESMF Github just yet though, so possibly just an iris-esmf-regrid issue, but pinning that instead is no bueno, since we'd better have their latest version up, and that works fine with older ESMF/Py's according to Manu.

~Also remove esmpy from setup.py~ -> not on PyPI anymore, they get their source for the package straight from Github packages https://github.com/conda-forge/esmpy-feedstock/blob/main/recipe/meta.yaml but we should still keep it in our Py index

valeriupredoi commented 5 months ago

same here, reinstated it in https://github.com/ESMValGroup/ESMValTool/pull/3585/commits/b17351b28f11b5320a6c97ed9e6301027b93fa2b

valeriupredoi commented 5 months ago

Looks good to me, thanks V!

If you want to align Core and Tool environment even more, you could also add the pins to pandas:

pandas !=2.2.0,!=2.2.1,!=2.2.2 # github.com/ESMValGroup/ESMValCore/pull/2305

I noticed that pandas gets pulled from PyPI in the pip install step of ESMValCore for a development installation, which can be solved with the fix above.

a good call, Manu! Did that for the envs in https://github.com/ESMValGroup/ESMValTool/pull/3585/commits/fdac45d7330d39428c1668983a5e5afc90f74ee4 and setup.py in https://github.com/ESMValGroup/ESMValTool/pull/3585/commits/d91c2305c6741d56a94a803255ff354390325570 :beer: