Closed ehogan closed 1 month ago
Thanks! Could you please do the checklist?
Thanks! Could you please do the checklist?
Apologies, now done! ๐ Although, it did make me wonder whether I should add a pin to cdo (>=2.3.0
) as remapscon2
will only work from v2.3.0 onwards ๐ค
Thanks, that's why we have the checklist ;-) Updating the pin sounds like a good idea.
Thanks, that's why we have the checklist ;-) Updating the pin sounds like a good idea.
Thanks @bouweandela! ๐ฅณ Added in 618b6f8 ๐
@ehogan cdo on PyPI is old, stuck at 1.6.0 so pinning it in setup.py will trigger an actual search of the index, so it fails coz it can't find a requested version to satisfy the pin, I'd not pin it in setup.py, and just leave it pinned in the conda env file ๐๐บ
@ehogan cdo on PyPI is old, stuck at 1.6.0 so pinning it in setup.py will trigger an actual search of the index, so it fails coz it can't find a requested version to satisfy the pin, I'd not pin it in setup.py, and just leave it pinned in the conda env file ๐๐บ
Thanks @valeriupredoi; I removed the pin in setup.py
in b929755. I also realised I hadn't added it to environment_osx.yml, so I did that in bfe68d9 ๐
Many thanks @ehogan all looks good to me, @bouweandela maybe you could approve and merge when you got a minute ๐บ
cdo on PyPI is old, stuck at 1.6.0 so pinning it in setup.py will trigger an actual search of the index, so it fails coz it can't find a requested version to satisfy the pin, I'd not pin it in setup.py, and just leave it pinned in the conda env file
That is not quite correct. The cdo package on PyPI is on conda-forge as python-cdo. This is a Python wrapper around cdo, not cdo itself. See https://github.com/conda-forge/python-cdo-feedstock/blob/main/recipe/meta.yaml.
Description
Closes #3610
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐ Technical or ๐งช Scientific review.