Warnings during full development installation

[schlunma]

When doing a full development installation of ESMValTool, the pip install step for ESMValCore raises the following warnings:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
prospector 1.10.3 requires flake8<6.0.0, but you have flake8 7.0.0 which is incompatible.
prospector 1.10.3 requires pyflakes<3,>=2.2.0, but you have pyflakes 3.2.0 which is incompatible.

See also https://github.com/ESMValGroup/ESMValTool/actions/runs/9342587884/job/25710921454.

@ESMValGroup/technical-lead-development-team

P.S. The installation is "successful", it looks like the ERROR is just treated as a warning.

[valeriupredoi]

@schlunma good spot and good reporting! This comes from esmvalcore literally dropping prospector so we can support python=3.12 - flake8 had to be upgraded, but since the latest flake8 is incompatible with prospector (remember my rant about it), @bouweandela and me we just dropped prospector from esmvalcore's requirements. The process is as follows:

• you install ESMValTool from source (which grabs esmvalcore from conda-forge, an esmvalcore that comes with flake8==5)
• you then install esmvalcore from source which overrides the conda-forge one, and in the process, it uninstalls flake8==5 and installs flake8==7, but does not move or change prospector (already installed)
• pip sees this and complains a little bt (more like a squeal than a cry) that you now have flake8==7 which is not compatible with prospector=1.10.3 (and rightly so!)
• try and run prospector after this, and you will run in some troubles (it doesn't run properly)

Here's Circle's install artifact that reproduces this issue: https://circleci.com/api/v1.1/project/github/ESMValGroup/ESMValTool/74368/output/105/0?file=true&allocation-id=665d084d20ca3006ff595fa3-0-build%2FABCDEFGH

This issue will be resolved soon, when we will completely remove prospector from ESMValTool's dependencies, so we can support python=3.12 there too; until then, all works fine, apart from prospector :grin:

[bouweandela]

Let's first see if all other dependencies become available for Python 3.12 and then we can see about dropping prospector. In the long run I would like to switch to ruff, but it would be rather nice if Codacy supported it so we don't lose the webpage with linting results.

[valeriupredoi]

@bouweandela absolutely fair point, here's the PR that will give us support for Python 3.12 https://github.com/ESMValGroup/ESMValTool/pull/3501 - allis fine apart from:

• ncl blocking esmf >=8.6.0
• psy-reg needing support for python 3.12 (am in touch with Philipp)
• and still, prospector

[valeriupredoi]

methinks this is good to close, Manu? :beer:

[schlunma]

I just did a fresh installation and the warnings still appear. I guess they will only disappear when we drop prospector?