ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 122 forks source link

Add `rose macro -V` command to `rtw-tests.yml` Github Workflow #3649

Closed chrisbillowsMO closed 1 week ago

chrisbillowsMO commented 3 weeks ago

Description

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number of pull requests:

If you need help with any of the items on the checklists above, please do not hesitate to ask by commenting in the issue or pull request.

alistairsellar commented 2 weeks ago

@alistairsellar do you remember the conversation we had with Oliver about potentially grouping options via namelists? I'm wondering whether it's worth doing this for the options that we must duplicate in the rose-suite.conf file (because they are defined in e.g. opt conf files) so we can separate them under a "users must not edit these options as they are defined in opt conf files" list? ๐Ÿค”

Yes, that seems sensible. That list could be called something like "site-specific settings, do not edit".

ehogan commented 2 weeks ago

@alistairsellar do you remember the conversation we had with Oliver about potentially grouping options via namelists? I'm wondering whether it's worth doing this for the options that we must duplicate in the rose-suite.conf file (because they are defined in e.g. opt conf files) so we can separate them under a "users must not edit these options as they are defined in opt conf files" list? ๐Ÿค”

Yes, that seems sensible. That list could be called something like "site-specific settings, do not edit".

Great! ๐Ÿ‘ @chrisbillowsMO, I will leave it up to you whether you would like to do the above work; if not, would it be possible for you to open a new issue (and assign it to me), please? ๐Ÿ˜Š

chrisbillowsMO commented 1 week ago

@alistairsellar do you remember the conversation we had with Oliver about potentially grouping options via namelists? I'm wondering whether it's worth doing this for the options that we must duplicate in the rose-suite.conf file (because they are defined in e.g. opt conf files) so we can separate them under a "users must not edit these options as they are defined in opt conf files" list? ๐Ÿค”

Yes, that seems sensible. That list could be called something like "site-specific settings, do not edit".

Great! ๐Ÿ‘ @chrisbillowsMO, I will leave it up to you whether you would like to do the above work; if not, would it be possible for you to open a new issue (and assign it to me), please? ๐Ÿ˜Š

Alas no time! ๐Ÿ˜ญ I've raised it as a new issue here: #3679