ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 121 forks source link

Fix issues with the radiation budget recipe #3653

Open mo-gill opened 2 weeks ago

mo-gill commented 2 weeks ago

Description

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.

mo-gill commented 2 weeks ago

Updated the rev of R as the pre-commit wasn't working in commit https://github.com/ESMValGroup/ESMValTool/pull/3653/commits/d7dec58029bee4ae257c8c5877c71749c557e455

valeriupredoi commented 6 days ago

OK the RTD import issue is reproducible:

(esmvaltool) valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ conda list psy
# packages in environment at /home/valeriu/miniconda3/envs/esmvaltool:
#
# Name                    Version                   Build  Channel
psy-maps                  1.5.0           py311h38be061_1    conda-forge
psy-reg                   1.4.0           py311h38be061_3    conda-forge
psy-simple                1.5.0           py311h38be061_1    conda-forge
psyplot                   1.5.0           py311h38be061_1    conda-forge
(esmvaltool) valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ python esmvaltool/diag_scripts/psyplot_diag.py
WARNING:psyplot.config.rcsetup:Failed to import EntryPoint(name='plugin', value='psy_reg.plugin', group='psyplot')!
WARNING:psyplot:Could not import EntryPoint(name='plugin', value='psy_reg.plugin', group='psyplot')
Traceback (most recent call last):
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/psyplot/__init__.py", line 132, in get_versions
    mod = ep.load()
          ^^^^^^^^^
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/importlib_metadata/__init__.py", line 184, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/valeriu/miniconda3/envs/esmvaltool/lib/python3.11/site-packages/psy_reg/plugin.py", line 36, in <module>
    from psyplot.compat.pycompat import map, filter
ModuleNotFoundError: No module named 'psyplot.compat'
usage: psyplot_diag.py [-h] [-f] [-i] [-n] [-l {debug,info,warning,error}] filename
psyplot_diag.py: error: the following arguments are required: filename

@schlunma seen this before? If not, I'll ping Philipp about it :beer:

valeriupredoi commented 6 days ago

@schlunma nay bother, we have it all in https://github.com/ESMValGroup/ESMValTool/issues/3638

bouweandela commented 6 days ago

note that the documentation build is failing because of this warning, not because of linked issue.

/home/docs/checkouts/readthedocs.org/user_builds/esmvaltool/checkouts/3653/doc/sphinx/source/gallery.rst:482: WARNING: undefined label: 'c'

valeriupredoi commented 6 days ago

well how is that possible since I just merged main here?

valeriupredoi commented 6 days ago

at any rate - the problem with psy-reg is a bit more far-reaching than just the docs, that actual import psyplot.project as psy is failing, so the diagnostic itself is unusable

bouweandela commented 6 days ago

well how is that possible since I just merged main here?

The issue is introduced in this pull request. Maybe one of those copyright (C)s is getting interpreted as a rst label?

valeriupredoi commented 6 days ago

well how is that possible since I just merged main here?

The issue is introduced in this pull request. Maybe one of those copyright (C)s is getting interpreted as a rst label?

ah gotcha, thanks, bud! @mo-gill please fix that then, cheers :beer: Well this lead to another, I fixed the psy-reg plugin issue in https://github.com/ESMValGroup/ESMValTool/pull/3687