Closed ehogan closed 5 days ago
Describe the bug The following R recipes failed in the recent ESMValCore v2.11.0rc1 testing:
Error in (!is.null(d$longname)) && (nchar(d$longname) > 0) : 'length = 2' in coercion to 'logical(1)' Calls: nc_create -> ncvar_add -> ncdim_create
Error in (!is.character(filename)) || (nchar(filename) < 1) : 'length = 2' in coercion to 'logical(1)' Calls: gleckler_main -> gleckler_array -> nc_open
Error in (models_dataset == reference_dataset) && (models_exp == reference_exp) : 'length = 2' in coercion to 'logical(1)' Calls: which
According to https://cran.r-project.org/doc/manuals/r-release/NEWS.html, v4.3.0 introduced the following change:
Calling && or || with LHS or (if evaluated) RHS of length greater than one is now always an error, with a report of the form 'length = 4' in coercion to 'logical(1)'
Calling && or || with LHS or (if evaluated) RHS of length greater than one is now always an error, with a report of the form
'length = 4' in coercion to 'logical(1)'
Possible solutions:
<4.3.0
(all(models_dataset == reference_dataset)) && (all(models_exp == reference_exp))
However, this wouldn't fix the first and second issues, as I can't find these lines in ESMValTool anywhere, which leads me to believe that they are from an R dependency, likely one of nc* functions.
nc*
Describe the bug The following R recipes failed in the recent ESMValCore v2.11.0rc1 testing:
According to https://cran.r-project.org/doc/manuals/r-release/NEWS.html, v4.3.0 introduced the following change:
Possible solutions:
<4.3.0
However, this wouldn't fix the first and second issues, as I can't find these lines in ESMValTool anywhere, which leads me to believe that they are from an R dependency, likely one of
nc*
functions.