ESMValGroup / ESMValTool

ESMValTool: A community diagnostic and performance metrics tool for routine evaluation of Earth system models in CMIP
https://www.esmvaltool.org
Apache License 2.0
210 stars 121 forks source link

Merge the RTW documentation with the ESMValTool documentation #3684

Closed ehogan closed 6 days ago

ehogan commented 1 week ago

Description

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number of pull requests:

ehogan commented 1 week ago

Great stuff @ehogan! Exciting to be completing the prototype!

๐Ÿฅณ

Just two suggested changes:

  • one in the comment below (utils structure) and

I'll address this in the comment ๐Ÿ‘

  • can/should we move the actual workflow dir esmvaltool/utils/recipe_test_workflow/recipe_test_workflow up one level, now that esmvaltool/utils/recipe_test_workflow doesn't contain the doc dir?

Yes, I was planning to do this via a separate PR after this (which will include a final sanity check of the documentation to ensure the documentation uses the correct paths etc.) ๐Ÿ˜Š

alistairsellar commented 1 week ago

Yes, I was planning to do this via a separate PR after this (which will include a final sanity check of the documentation to ensure the documentation uses the correct paths etc.) ๐Ÿ˜Š

Sounds good - thanks!