Fix contourf plots for masked data

schlunma commented 3 weeks ago

Description

See https://github.com/SciTools/cartopy/issues/2468: contourf with transform_first=True does not handle masked data correctly. Thus, we use a filled array with np.nan here which works correctly.

Related to

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Documentation is available
[x] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

[x] 🧪 Recipe runs successfully
[x] 🧪 Recipe is well documented
[x] 🧪 Figure(s) and data look as expected from literature
[x] 🛠 Provenance information has been added

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

schlunma commented 3 weeks ago

@esmvalbot please run monitor/recipe_monitor_with_refs.yml

esmvalbot[bot] commented 3 weeks ago

Since @schlunma asked, ESMValBot will run recipe monitor/recipe_monitor_with_refs.yml as soon as possible, output will be generated here

esmvalbot[bot] commented 3 weeks ago

ESMValBot is happy to report recipe monitor/recipe_monitor_with_refs.yml ran OK, output has been generated here

valeriupredoi commented 3 weeks ago

swanky plots, do they look the way you wanted them to look, Manu? :beer:

schlunma commented 3 weeks ago

Yes Sir! They look identical to https://esmvaltool.dkrz.de/shared/esmvaltool/stable_release/recipe_monitor_with_refs_20240523_095356/

schlunma commented 3 weeks ago

BTW, it's so nice that the bot is back again! 🤖

valeriupredoi commented 3 weeks ago

BTW, it's so nice that the bot is back again! 🤖

it's a wee one but does wonders :grinning:

schlunma commented 3 weeks ago

code looks good! The only wiggle I can think of is that this may break after cartopy fixes their show, if they treat NaNs in a special way - don;t think this will be the case though

Thanks for reviewing! Don't think that's the case - for example, xarray only uses nans instead of numpy arrays, and I did successful contourf plots with that if I remember correctly 👍

ESMValGroup / ESMValTool