search

ESN-Trondheim / ESNbot

A Slack bot for ESN Trondheim
MIT License
3 stars 1 forks source link

Fixed Issue #33 #37

Closed ziegenludwig closed 10 months ago

ziegenludwig commented 10 months ago

Changed concatenating print statements to f-strings to improve reading ability and performance.

LaiAlexander commented 10 months ago

Hi @ziegenludwig ! Thank you for your contribution!

This is still missing some strings that may be converted to f-strings. Some examples (this is not a complete list) https://github.com/ziegenludwig/ESNbot/blob/c0fbc96a7cc67048eccceca4f7b5ecd44f7c14e3/esnbot/commands.py#L57

https://github.com/ziegenludwig/ESNbot/blob/c0fbc96a7cc67048eccceca4f7b5ecd44f7c14e3/esnbot/commands.py#L60-L61

https://github.com/ziegenludwig/ESNbot/blob/c0fbc96a7cc67048eccceca4f7b5ecd44f7c14e3/esnbot/main.py#L31-L32

ziegenludwig commented 10 months ago

I think I should of gotten most if not all now.