search

ESOUIMods / LibQuestData

3 stars 5 forks source link

LibQuestData Data Collection #1

Closed Sharlikran closed 1 year ago

Sharlikran commented 4 years ago

File and Location

Typical location

The file you want to provide is LibQuestData.lua from your SavedVariables folder.

Typical location: C:\Users\[your user name]\Documents\Elder Scrolls Online\live\SavedVariables

Image of the file needed

image

PVE Zones

Grahtwood

Stros M'Kai

Smuggler's Den

Greenshade

Deshaan

Southern Elsweyr

The Rift

Hew's Bane

Northern Elsweyr

Coldharbour

Auridon

Stonefalls

Reaper's March

Unknown Zone (Most seem like Craglorn)

Murkmire

PVP Zones

Cyrodiil

Necropsi commented 4 years ago

this happened when i finished the quest! should i continue or wait for update?

is it maybe becouse i had started quest before installing LibQuestInfo? i still had log and scout when i started the quest yesterday

image

Necropsi commented 4 years ago

and i did daily writs in vvardenfell and there was no error, but .lua file is still empty, even when i exited the game, is that normal?

image

Sharlikran commented 4 years ago

For the writs yes, I am not collecting that over and over and over and over and over depending on where you stand. I have to make a routine to grab it once and then stop collecting it. For next version.

Necropsi commented 4 years ago

ok, just wanted to make sure. what about the error? should i keep on questing or wait for update?

Sharlikran commented 4 years ago

Whatever you decided is fine. I have a new version up to fix your error.

Necropsi commented 4 years ago

i waited. tried it now, no error and stuff is being writen in .lua. Thank you! will finish vvardenfell tomorrow!

Necropsi commented 4 years ago

Ok i am finaly finished with Vvardenfell! sorry for taking so much time. There was no red quest in Journal Quest Log, so i didnt miss any of the quests cuz of the dessicions i made. I did all 4 repeateble quests, including writs, at least once. So my log is absolutly complete except for these quests:

https://en.uesp.net/wiki/Online:Forging_the_Future (i didnt find group to do repeateble trial quest) https://en.uesp.net/wiki/Online:Breaking_Through_the_Fog (i didnt have AddOn enabled while i did this quest) https://en.uesp.net/wiki/Online:At_Any_Cost (AddOn had error when i finished this quest) Battleground Quests

Everything else is done!

I submited my Scout and Log files yesterday and here is the LibQuestInfo .lua!

I am off to ClockWork City, should i submint .lua when i am done?

LibQuestInfo.zip

Sharlikran commented 4 years ago

I would wait on clockwork city for now. I have some things to do but I'm trying to get another update finished for LibQuestInfo that includes a bit more data that you have provided including your submission for Vvardenfel. Thank you for your work and tomorrow, or later really, when you have time then maybe do some quests after my next update.

Necropsi commented 4 years ago

ok, will wait for update, then do full ClockWork City!

Sharlikran commented 4 years ago

@Necropsi Alright, go ahead and see what you can do for ClockWork City after getting v1.3 installed.

Necropsi commented 4 years ago

ok, i started CWC yesterday, will submit .lua when i am sure i completed it 100% (trial quest will probably be missing)!

i saw Vvardenfell was added, that is awesome! :) but i noticed that 2 of the quests that i am sure are in this zone are not there. info for this quests should be in LibQuestInfo.lua that i submited last. quests are called: https://en.uesp.net/wiki/Online:If_the_Spell_Fits https://en.uesp.net/wiki/Online:A_Web_of_Troubles

is that normal, was my LibQuestInfo.lua not imported yet or is it not working properly yet?

image

Sharlikran commented 4 years ago

I have several files to go through. It was easier for me to make ways to record and store the information. It is still pretty simple to import it all but I am finding issues here and there. Another thing I found was some information from you was up to date with each change I made to Quest map Scout. Thank you for that.

Other information I received from other sources was sometimes from Quest Map Scout 1.0.11 or 1.0.12. So I spent more time coming up with ways to import it then using what I hoped to use, which should have been more fluid.

I really appreciate your help and I will verify the information today from your LibQuestInfo.zip.

Necropsi commented 4 years ago

yeah i understand!

well i check for updates everytime time before i run the game, glad that helped!

will submit whole clockwork data as soon as i finish it!

Sharlikran commented 4 years ago

@Necropsi I just updated things with the those quests. I was surprised to see that my main has not done one of the quests you mentioned was missing. I was oooooo wowowowowwwwwwww I need to do that quest now! So that was a pretty cool moment.

After you are done with clockwork city I need to finish up the rough draft. That will mean some repeatable quests, trials quests, and such may not be there still. I am ignoring Writs, Trials Quests, and Some daily quests for now until I get the final touches on the auto update routines.

If all goes well there is a chance I can move to phase two which will be verification. What that should do unless I make a minor mistake, is take a quest you accept in a zone, then if you want you can do the quest or just abandon it. Either way accepting and abandoning it verifies the quest information. Completing it verifies the Quest Reward Types.

I want to start tracking Quest Reward Types to see if the game automatically returns which quests award a skill point. It may not occur but I want to look into it.

Never the less verifying a zone should eliminate all the seemingly random pins scattered all around the zone.

Sharlikran commented 4 years ago

After you submit your Clockwork City data you should delete all QuestMap.lua, QuestMapScout.lua, QuestMapLog.lua, and LibQuestInfo.lua files if any are remaining.

Once I am ready for phase two LibQuestInfo will auto reset your saved variables file so you won't need to mess with it. It will start tracking what I need automatically.

Sharlikran commented 4 years ago

@Necropsi I am sorry to request this but I have finished my changes to LibQuestInfo for phase 2 to verify information. This changes two things.

First it changes Quest Map itself such that the settings are now account wide. No need to copy settings for each char. Because I no longer need a bunch of data collection, all that has been removed from Quest Map.

Second I have optimized what I save for LibQuestInfo and the conditions for saving the information. I also clean up the data once you remove a quest so that all of the information I obtain is already in the format I need.

I am hoping the changes will help me import the information more smoothly. When you see this please upload your LibQuestInfo.lua file from your saved variables folder. Then make a backup or zip file of it, then delete it. Once you see me respond then wait for LibQuestInfo to be approved on ESOUI and download it. I will also update QuestMap at the same time and they will both need to be updated for QuestMap to function.

Thank you for your understanding I am going to test my verification routines for a while and see how it goes.

If all goes well I will be able to accept and abandon quests and have the information I need without actually doing the quests. Again, except for the Main Story quests that you have to do in a specific order. I just hope the changes work more smoothly this time.

Sharlikran commented 4 years ago

@CaptainBlagbird Just a heads up. Backup your PTS data please prior to updating Quest Map and LibQuestInfo. If you don't the data will be erased. I will PM you on ESOUI also. Feel free to upload your LibQuestInfo.lua also and I can spend some time getting that integrated into the next version.

Necropsi commented 4 years ago

haha glad to hear that :) was it the Stibbons one or the naked drunk nord one? :)

we are so far that i think we can just finish the quests by this stage, but it will sure come in usefull for the future! i will just complete CWC old fashion way since i didnt play that zone yet. what zones do we have missing after that?

if the random pins and duplicated pins would disapear that would be awesome!! :) after that a few more filters and this addon will be perfect!

no need to apolagize :) we are all just glad that we are doing this :)

ok here is the file, and i will keep the backup, deleted it, but there is still no update for AddOn. (plus i only just did 2 or 3 quests in CWC, didnt have that much time, will do more now over weekend.) im guessing i cant play now till update?

LibQuestInfo.zip

Necropsi commented 4 years ago

oh and i am using Journal Quest Log addon to make sure i complete everything in the zone. it gets data from UESP, and it just adds a tab to your quest jurnal, leting u know what quests u completed and didnt completed in a given zone. i find some of the missing quests even in the zones that have QuestMap pins, so maybe check it out if u want to make sure u didnt missed any :)

https://www.esoui.com/downloads/info1785-JournalQuestLog.html

Sharlikran commented 4 years ago

@Necropsi My sons computer was having issues so I have been busy with that so much I didn't finish something I wanted. So no worries. I will test my changes with your file and make sure it preserves some of the data instead of resetting it. So you should be able to restore you LibQuestInfo because I had a brainstorm today as to what I can do. I'll let you know when I'm done.

Necropsi commented 4 years ago

no problem :) so if i understand i just unzip the file i deleted and keep playing?

Sharlikran commented 4 years ago

I believe that should be possible, yes. I am going to use your file right now to test my changes. That way once I update the mod on ESOUI you won't have to do anything but keep playing and the update won't break anything. So having the file will still be a big help. Thanks.

Necropsi commented 4 years ago

nice! I created a repeatable versions of icons, with original colour, if in future we can use different icons for repeatable quests! (original icon should be somewhere in the games files) icons.zip image

Sharlikran commented 4 years ago

@Necropsi I am done with my changes and testing. It should hopefully seem as if nothing changed. If you have any errors let me know but it should just do what it is intended to do. In case you do view the LibQuestInfo.lua file from time to time you will notice it has different categories in it. It will also clear out some quest data once it is used. So some information will be removed after it is used to build other data.

Necropsi commented 4 years ago

ok, just finished quest and no errors!

another thing is fixed, taking and finishing writs with Lazy Writ addon has been lagging since your last update, but its back to normal with this one!

Sharlikran commented 4 years ago

Yeah I don't want you to think I am unappreciative of the quest info but I want the writs, dailies, and other repeatable quests to be handled by v1.6 which is the version I just released with my new attempt at data collection.

There are simply too many entries for it in each zone I need a streamlined way to get one pin or verify one pin and eliminate the rest.

I may have some more errors and obstacles but I'm going to keep trying to figure out how to get that to work properly.

So if I leave out any writs, dalies, or repeatable quests please don't take it the wrong way I'm just trying to come up with an automated system for that because those are duplicated the most.

Sharlikran commented 4 years ago

After I get your next upload of the rest of your data for clockwork, then that is when (hopefully) repeatable quests can start to get optimized.

After I enter the data (not your previous data) then I need you to check all the main quests and side quests to be sure I didn't miss any. Just the regular quests not the repeatable ones. Again after I get your next batch of data.

Necropsi commented 4 years ago

nice, and no problem at all! :)

clockwork city might be done today if i no-life it :) tomorrow for sure! i have 4 main, 9 side, and 4 dailies left.

Sharlikran commented 4 years ago

4 dailies left.

Remember that's what I'm mentioning. Don't worry about the daily quests yet. I haven't come up with a good system for that. I'm still manually copying and pasting things and so I'm overlooking those particular Quests for right now because I want just the main quests and not the repeatable things because there's too much duplication.

The data I'm looking at is all numbers so you can't look at a number and just have memorized at that number means it is a specific quest and there's so much information. If I have 50 to 90 quests in one zone I can't easily find one number in that one zone.

Sharlikran commented 4 years ago

@Necropsi LOL I was on my phone and somehow edited your message instead of replying to it. I had an e-mail notification and was able to use that as a history and restore it. Darn phone.

Necropsi commented 4 years ago

hehe, no problem :)

ok so this is a completed file for Clockwork City. i just didnt do any of the dailies since u said i dont have to (i can do them when u need em), and trial quest, i just took it and abandoned it.

there were no red quests in Jurnal Quest Log, so this is 100% complete (event he one for target dummy)! there were few quests missing from what u have already added.

one thing i noticed. in Vvardenfell i saw some quests that i already did, and some quests from other zones. do you maybe need names of this quests or can u sort that out in some other way?

what zones are still missing? LibQuestInfo.zip

Necropsi commented 4 years ago

one more thing! i talked to guy ( https://www.esoui.com/forums/member.php?userid=12447 ) who is updating Jurnal Quest Log addon ( https://www.esoui.com/downloads/info1785-JournalQuestLog.html#info ). when quest cannot be taken, becouse of the disicions u make as a player, or becouse u are further down that quest line already, they turn red in his addon. i was thinking, could the same comman that turns that quest red, also automaticly hide it in QuestMap?

image

Sharlikran commented 4 years ago

Maybe I could try to add features later but not for now.

I'll try to get all that into LibQuestInfo today so I can release a new version.

As far as zones I would like to wait and not try to do anything else for now.

I'm doing the pts for just a simple rough draft. I had most of the quests done a while back but it was when I used a older Quest Map Scout that didn't save the questID so I had no way to use it. I had a brain storm though. The map pin mod doesn't care about quest name and all that stuff. If you say draw a pin at x,y then it does it. So I just used that to show where I had been and just ran around to those places. It won't be complete but it will be good enough. I should have a decent version ready for launch tomorrow.

Have fun.

CaptainBlagbird commented 4 years ago

Here's my progress in Western Skyrim and Blackreach so far: LibQuestInfo.zip

Sharlikran commented 4 years ago

@CaptainBlagbird Thank you. That will ensure I get the most pins possible for my rough draft for tomorrow.

Sharlikran commented 4 years ago

@Necropsi Well between version 1.6 and 1.8 I had made my final update routines that break up the information better for me to manually copy paste it into the files until I figure out better update routines. I had mentioned it should not be an issue but I forgot that at about version 1.8 the error reports were more frequent. Turns out nothing was really wrong just minion or ESO not updating the .lua file properly. Which I verified by having someone give me their .lua file that was having the error.

Your diligence and always updating might have made it loose some info for clockwork after all. I am sorry about that. After the next update maybe just enable completed quests and double check and see if they are all there.

Sharlikran commented 4 years ago

@CaptainBlagbird Thank you I have your information in LibQuestInfo and it will be in the next version. I'm just going to run around and try to double check a few things this evening before I make my final rough draft release.

Necropsi commented 4 years ago

will do!

CaptainBlagbird commented 4 years ago

Here are some more quest locations for Western Skyrim. I completed some already started quests and only started quests that were not already collected by libQuestInfo. Next I'll look in Blackreach if I can find some uncollected locations.

LibQuestInfo.zip

Sharlikran commented 4 years ago

Thank you very much I will take a look. Thank you for having the latest version installed. It helps prevent duplicate information.

CaptainBlagbird commented 4 years ago

I used the latest that is installed with Minion. Should I use the latest from the master branch here instead?

Necropsi commented 4 years ago

i think its all there!

Sharlikran commented 4 years ago

@CaptainBlagbird The version you install with Minion would be best.

@Necropsi I am glad all the Clockwork stuff seems to be there. Ty.

Necropsi commented 4 years ago

Hey! hope all is good.

game lags after finishing quest, but i am not sure if its cuz of this addon, anybody else have same problem?

Sharlikran commented 4 years ago

It might when you turn in a quest. Should not lag after that. I'm going to rewrite things later. I may release a slightly different version, and other improvements incrementally. However, by the weekend at least I hope to have a more refined version. With hopefully more optimized routines.

I will overhaul the whole thing over the next month. It will only obtain data from the main array of locations for drawing the 2D pins on the world map.

For the zone you are currently in that will be in a different array and you won't have to fetch it each time. It will refresh only when you change zones and only when you travel to a different zone. It won't change when the game glitches and you move to a loading screen and puts you in a different instance or when you use a way shrine for the same zone.

Sharlikran commented 4 years ago

@CaptainBlagbird

I used the relative scale from the API. This scale always ranges from 0 to 1 of the current map (so 0,0 being the top left corner of the current map I think, and 1,1 being the bottom right). That means, that each point of a subzone (e.g. a town) is located somewhere within 0,0 and 1,1 of the actual zone. So I created a helper addon that marks point 0,0 of the subzone and checks what point it is on the zone. Then the same with point 1,1 of the subzone. With both points in the zone I could calculate how large and where the subzone is according to the zone (--> x, y, zoom_factor).

Do you happen to still have that helper addon routine?

CaptainBlagbird commented 4 years ago

@Sharlikran Yes, I still have it. I'm currently at work, but I can upload it during lunch break (in about 1.5h).

Sharlikran commented 4 years ago

@CaptainBlagbird after work is fine. I'm going to bed so no rush. Enjoy your lunch instead. RL is way more important. Take care.

Sharlikran commented 4 years ago

@CaptainBlagbird When you have time after work can you attach the helper file to this issue? That way I'll get a notification.

Sharlikran commented 4 years ago

Because I have not found any libraries that seem to calculate anything close to the values you have.