search

ESP32-WiPhone / wiphone-firmware

Arduino ESP32 firmware for the WiPhone
37 stars 4 forks source link

Enable caret cursor in dial app #30

Open xopr opened 2 years ago

xopr commented 2 years ago

When the user starts to dial (ENTER_DIAL_APP -> GUI_APP_DIALING), there is no visual indication where the cursor is.

This might especially be confusing after the first WIPHONE_KEY_LEFT event where a user can insert or delete digits in the middle of the dialed number; caret enabling after the first event or when the position is not at the very end might be least intrusive solution.

nosliwneb commented 2 years ago

you can't see that black cursor on the black background? :)

(I'm guessing, but 90% sure that's what's happening)

yeah, we do need to add (or show) the cursor Message ID: @.***>

xopr commented 2 years ago

@nosliwneb you're right, I had a look at the input widgets and they all show a (fixed color) caret. I think this patch should fix it, but I'm currently unable to test it. (let me know if you have problems with a public patch and I'll make the repo private for the time being. Note: it has no actual source, only patches and a build mechanism)