search

ESPRI-Mod / synda

ESGF Downloader (this is a deprecated repository, the tool has now moved to https://github.com/ESGF/esgf-download)
https://espri-mod.github.io/synda/
21 stars 11 forks source link

Remove TLSv1 version pinning #136

Closed Zeitsperre closed 4 years ago

Zeitsperre commented 4 years ago

This PR fixes the following issue: #92

Justification

Several downloads have been failing for me due to a hard-coded TLSv1 version in the synda request. The error being that ESGF authorization credentials were not accepted. I'm not sure if there are servers that still demand this protocol, but looking through the revision history of the file, I can see that this options has been set in place for for >5 years.

Additional Information

This tool has been integral to me for collecting and maintaining the archives of CORDEX and CMIP5 data of my employer. Great work!

AtefBN commented 4 years ago

Thanks for this PR @Zeitsperre I'll merge as I don't see any conflict with the existing version. Just a heads up, in the near future, I plan on releasing a python 3.7 version of Synda, with plenty of refactoring. One of which I hope is getting rid as much as possible of external bash files and keep synda a pure python tool. Which is why I'm replacing the wget calls by native python http requests. This should make Synda much more maintainable and easy to debug. Happy you are happy with Synda by the way!