ESPRI-Mod / synda

ESGF Downloader (this is a deprecated repository, the tool has now moved to https://github.com/ESGF/esgf-download)
https://espri-mod.github.io/synda/
21 stars 11 forks source link

Continue on cert errors #164

Open painter1 opened 3 years ago

painter1 commented 3 years ago

This is a replacement for pull request 145, issued in May 2020. It does the same thing, but request 145 was compatible with the master branch in May, and this is compatible with the current master branch. If the master branch changes again, I will not redo this request.

The purpose of this patch is to allow use of Synda when a identity server is down, unable to renew certificates; but the existing certificates are still valid. In this case, Synda can and should continue to work normally - with rare exceptions when a certificate has actually expired.

If the user does nothing, then there is no change from the present behavior of Synda. But if the user sets "continue_on_cert_errors=true" in the download section of his configuration file, then certificate errors will be essentially ignored. Specifically, when sddmdefault.transfers_begin() encounters an exception while renewing a certificate, then it will simply continue.

This small change is essential to production-scale operation of Synda for replication, and prevents an occasional confusing error for all uses of Synda. The reason for requiring a setting in the configuration file is that there is a certain small risk, and the user should be aware of it.