search

ESPRI-Mod / synda

ESGF Downloader (this is a deprecated repository, the tool has now moved to https://github.com/ESGF/esgf-download)
https://espri-mod.github.io/synda/
21 stars 11 forks source link

Master branch update broke sdnexturl.py #168

Closed painter1 closed 3 years ago

painter1 commented 3 years ago

The Synda in the latest master branch (f0beaec41e944126bee510d6850740bfa2068ede) omits the code in sdnexturl.py which pertains to remove_unsupported_url(). This breaks the url calculation and leads to a hard crash (not a Python exception).

pjournou-ipsl commented 3 years ago

Thank you for your message. This bug is now fixed (commit 287d3ea...).

painter1 commented 3 years ago

Thank you. That will prevent a crash. Is there another place which ensures that sdquicksearch.run() will not return useless urls, i.e. OpenDAP or Globus?

pjournou-ipsl commented 3 years ago

We removed the globus and opendap features, so we can ensure that sdquicksearch.run() will not return useless urls.

Last news about synda : we have encountered some troubles during the deployment of our last synda versions on anaconda platform due, particularly, to the major paradigm change (migration from python 2 to python 3). We hope the 3.32 latest version will give full satisfaction.

painter1 commented 3 years ago

That's good news to me - dropping globus and OpenDAP from sdquicksearch.run() simplifies the rest. I'll close this issue.