search

ESSS / pytest-regressions

Pytest plugin for regression testing: https://pytest-regressions.readthedocs.io
MIT License
179 stars 35 forks source link

doc for user specified datadir #157

Closed ronarbo closed 7 months ago

ronarbo commented 8 months ago

Proposed changes for issue #132

nicoddemus commented 8 months ago

Thanks @ronarbo for the PR!

I like the documentation changes, however I do not think we should change the actual code to introduce those configuration variables and use them on our own test suite. Did you do it as a means to test that what the documentation says is accurate?

ronarbo commented 8 months ago

Thanks @nicoddemus for your feedback. Yes, the additional tests are for testing the documentation and ensuring that it stays compatible with new pytest releases. Those new tests and the new variables in pytest.ini should not have any impact on the existing tests. Would you like me to remove those changes?

nicoddemus commented 8 months ago

I would, thanks. :+1:

nicoddemus commented 7 months ago

FYI I also updated the text a bit, focusing on the technique of overwriting the fixtures more.

nicoddemus commented 7 months ago

Thanks @ronarbo for the contribution, appreciate it!