search

ETDA / soda-etax

Other
13 stars 19 forks source link

Add contribution rules #7

Closed mahasak closed 7 years ago

mahasak commented 7 years ago

I have add contributtion rule as CONTRIBUTING.md to help us maintain our repository.

Please review and merge to master

varokas commented 7 years ago

In general. I think this is way too long. At least I suggest make the "How to contribute" section comes first with a few simple rules on how to contribute and how the repo owner will manage

Eg.

How to contibute

Then the next sections can be the boring legal stuff

mahasak commented 7 years ago

Should i split other section to other MD ? for example LICENSE.md, COC.md, HowToSubmitPR.md ?

mahasak commented 7 years ago

@iboss-ptk @varokas I'd manage to change regarding the comments, If you guys review and ok with it LGTM !!!!

varokas commented 7 years ago

LGTM.

Maybe we should add 2 more things according to this: https://www.facebook.com/mahasak.pijittum/posts/10214883212934174?notif_t=like_tagged&notif_id=1504938323613925

  1. Communicate in English 2.Pull Requests should have tests accompanied the code changes
varokas commented 7 years ago

I think we should have some rules about ( how long we need to wait || how many LGTM to get ) before merged.

iboss-ptk commented 7 years ago

I would be good to explain what LGTM means (looks good to me?). For new contributors, this might be confusing.

mahasak commented 7 years ago

@iboss-ptk LGTM -> Looks good to me, Let's get that moving, Let's get this merged :) Already add to markdown.

varokas commented 7 years ago

I will merge this tonight if theres no other comments

iboss-ptk commented 7 years ago

LGTM!