search

ETH3D / dataset-pipeline

Pipeline for creating multi-view benchmark datasets from laser scans and images.
BSD 3-Clause "New" or "Revised" License
151 stars 20 forks source link

Clement #3

Closed ClementPinard closed 4 years ago

ClementPinard commented 4 years ago

Hi,

as discussed by mails, this is a PR that tries to update the code to work with Ubuntu 18

For now, no feature are added, I just made the following fixes :

I also added a DockerFile to build from a blank ubuntu18

I have not added colmap's new camera models, as I have some troubles with the way camera distortion and undistortion are handled (I'll open a discussion in issues), but it will come shortly !

ClementPinard commented 4 years ago

Thanks for your insight ! I hopefully adressed all your comments.

Also, I forget to talk about it in the commit comments but I suppressed some warning regarding signed and unsigned comparison. This cleans the building console and eases debugging, but maybe it could be considered as information retention, so I can supress the corresponding files in the CMakeLists.txt if needed.

puzzlepaint commented 4 years ago

Thanks! Suppressing that warning seems fine to me.