search

ETHLend / Baiji-public

Baiji release issue reporting
0 stars 0 forks source link

[bug] Able to borrow without required collateral #55

Closed helpfulBrother closed 5 years ago

helpfulBrother commented 5 years ago

I have less than 3 ETH in my wallet, but am able to click take this loan and progress.

image

Also stuck on Validating Offer with same out of gas error as previous bug https://kovan.etherscan.io/address/0xF08087dF865f86A0A285C9c71BE78A8135091aae

The-3D commented 5 years ago

This is expected behavior, as it's simpler for the user, in terms of implementation and for compatibility, in the future, with external wallets. What is missing here is that the approve transaction dialog should recognize the balance and show the "insufficient funds" message (same behavior as metamask) which is related with issue #35. One of the few things that remaining to be implemented before the release

The-3D commented 5 years ago

if you try to send the transaction btw it will fail so it's an UI improvement that needs to be completed.

The-3D commented 5 years ago

i stand incorrect on this. I tried to replicate the error and i actually managed to get a loan without having the actual funds in the wallet. This happens only in the case of ETH as a collateral. This is a critical bug that will be addressed accordingly @sirsoth. Thanks