search

ETHZ-RobotX / SuperMegaBot

Main repository of the SuperMegaBot
20 stars 20 forks source link

Fix mapping due to breaking changes in O3D #30

Closed jk-ethz closed 1 year ago

jk-ethz commented 1 year ago

The interface of open3d_slam was changed in a non-backwards compatible way. This would break mapping during runtime on all new SMB/sim installations that pull via vcs.

@mantelt The easiest fix for me was to pin the last working RSS version. We could also migrate our rslidar .yaml files to the new .lua format, but it is not battle-tested on our platform and unclear if there are further changes required.

nubertj commented 1 year ago

In general, I would recommend upgrading, as many things have changed and improved since then. Moving from YAML to lua config should be a rather small change, and the new structure allows for better overlaying of different configs.

mantelt commented 1 year ago

Thanks for pointing this out @jk-ethz

We have our own branch of open3d_slam and using lua config files already. It is still in the dev repo, but should hopefully soon be tested and ready to merge into master. Once that is done, we will adjust the public smb.repos file.