ETHZ-TEC / RocketLogger

Official development repository of the RocketLogger project.
https://github.com/ETHZ-TEC/RocketLogger/wiki
BSD 3-Clause "New" or "Revised" License
14 stars 4 forks source link

Feature request: lossless sample aggregation #44

Open rdaforno opened 2 years ago

rdaforno commented 2 years ago

Currently, there is an argument to specify sample aggregation (averaging) for rates below 1kHz. However, this aggregation is lossy, i.e. if in only one sample within one aggregation block the valid bit is 0, the low current channel will be discarded entirely. Therefore, the aggregation method should be improved, for example by doing channel merging first and then aggregating the values (this of course will necessitate a new analog channel in the output file).

depends on: #16 relates to: #47

lsigrist commented 2 years ago

I've extracted the request for aggregation from sampling rates > 1 kSps and moved it to a new feature request as it deserves a dedicated discussion.

lsigrist commented 2 years ago

This is a good observation and a consequence of the currently data pipeline. As already noted this relates to current channel merging at runtime (#16). I even see #16 as a mandatory prerequisite for this feature request, because I see no alternative to the current approach of marking the full low current aggregation window as invalid:

Apart form this, I fail to see an alternative without linking or merging the two channels during acquisition that does not suffer from similar problems. But there may be other ideas around?